Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPMMA-2688 Smart Campaign Event Scheduling Based on Contact Behavior #302

Open
wants to merge 6 commits into
base: 5.x
Choose a base branch
from

Conversation

patrykgruszka
Copy link
Member

Docs for PR: mautic/mautic#13569

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small improvements to use hyphens instead of brackets - does this work?

docs/campaigns/campaign_builder.rst Outdated Show resolved Hide resolved
docs/campaigns/campaign_builder.rst Outdated Show resolved Hide resolved
docs/campaigns/campaign_builder.rst Outdated Show resolved Hide resolved
@patrykgruszka
Copy link
Member Author

Thanks @RCheesley, I've added your suggestions

@patrykgruszka patrykgruszka force-pushed the DPMMA-2688_smart-camapign-schedule branch from 18cdbc6 to 73109b7 Compare July 4, 2024 07:56
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some fixes for the issues Vale has flagged up.

docs/configuration/settings.rst Outdated Show resolved Hide resolved
docs/configuration/settings.rst Outdated Show resolved Hide resolved
docs/configuration/settings.rst Outdated Show resolved Hide resolved
docs/configuration/settings.rst Outdated Show resolved Hide resolved
@patrykgruszka patrykgruszka force-pushed the DPMMA-2688_smart-camapign-schedule branch from ef19780 to 23a548b Compare July 8, 2024 09:12
@patrykgruszka
Copy link
Member Author

I've updated the docs, thanks @RCheesley!

@RCheesley RCheesley requested a review from a team July 18, 2024 11:39
@RCheesley
Copy link
Member

The accompanying PR to this has conflicts so I am guessing it will be released in 5.2. I'll milestone it in the docs accordingly and we will merge accordingly.

@RCheesley RCheesley added this to the Mautic 5.2 milestone Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants