-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back the 2->3 upgrade docs #246
base: 4.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Plz remove the part where you name the plugins you are cleaning up
- Please remove the DB password
- Please change the sudo commands as they are not working like this in every environment
- Plz rewrite the code to work relatively and don't hardcore all your path
Ok got it will work on this |
Hi @Joseph2001-braganza are you still OK to make the tweaks requested from @jos0405 ? |
yes working on it. |
@jos0405 and @RCheesley Could you review my updated PR |
@Joseph2001-braganza please can you take a look at the Vale issues which are reported? Let us know if you need help with fixing them. |
sure will look into this . |
Hi @RCheesley , I have made the changes accordingly suggested by Vale, but it was showing me errors in some other files like readme.md and install Mautic page. I have only changed the "how to update the Mautic" or should I rectify those errors also ? |
There's still a lot of feedback that needs fixing @Joseph2001-braganza - just on this file. Check the files changed tab and it will show you what needs changing. |
Ok I will try to fix it . |
Hi @Joseph2001-braganza do you feel you can continue with this and address the feedback? |
Kindly Check the Documentation which I have updated for updating Mautic 2.x to 3.x.
If this is fine then I can move forward and add the documentation for 3.x to 4.x !
Thanks
Fixes #222