Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the 2->3 upgrade docs #246

Open
wants to merge 5 commits into
base: 4.x
Choose a base branch
from

Conversation

Joseph2001-braganza
Copy link

@Joseph2001-braganza Joseph2001-braganza commented Mar 4, 2024

Kindly Check the Documentation which I have updated for updating Mautic 2.x to 3.x.
If this is fine then I can move forward and add the documentation for 3.x to 4.x !
Thanks

Fixes #222

@RCheesley RCheesley requested a review from jos0405 March 7, 2024 11:43
Copy link

@jos0405 jos0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Plz remove the part where you name the plugins you are cleaning up
  2. Please remove the DB password
  3. Please change the sudo commands as they are not working like this in every environment
  4. Plz rewrite the code to work relatively and don't hardcore all your path

@RCheesley RCheesley changed the title updated the getting_started/how_to_update_mautic.rst Add back the 2->3 upgrade docs Mar 7, 2024
@Joseph2001-braganza
Copy link
Author

Ok got it will work on this

@RCheesley
Copy link
Member

Hi @Joseph2001-braganza are you still OK to make the tweaks requested from @jos0405 ?

@Joseph2001-braganza
Copy link
Author

Hi @Joseph2001-braganza are you still OK to make the tweaks requested from @jos0405 ?

yes working on it.

@Joseph2001-braganza
Copy link
Author

Hi @Joseph2001-braganza are you still OK to make the tweaks requested from @jos0405 ?

yes working on it.

@jos0405 and @RCheesley Could you review my updated PR
Thanks

@RCheesley
Copy link
Member

@Joseph2001-braganza please can you take a look at the Vale issues which are reported? Let us know if you need help with fixing them.

@Joseph2001-braganza
Copy link
Author

@Joseph2001-braganza please can you take a look at the Vale issues which are reported? Let us know if you need help with fixing them.

sure will look into this .

@Joseph2001-braganza
Copy link
Author

Joseph2001-braganza commented Apr 17, 2024

@Joseph2001-braganza please can you take a look at the Vale issues which are reported? Let us know if you need help with fixing them.

sure will look into this .

Hi @RCheesley , I have made the changes accordingly suggested by Vale, but it was showing me errors in some other files like readme.md and install Mautic page. I have only changed the "how to update the Mautic" or should I rectify those errors also ?

@RCheesley
Copy link
Member

There's still a lot of feedback that needs fixing @Joseph2001-braganza - just on this file. Check the files changed tab and it will show you what needs changing.

@Joseph2001-braganza
Copy link
Author

There's still a lot of feedback that needs fixing @Joseph2001-braganza - just on this file. Check the files changed tab and it will show you what needs changing.

Ok I will try to fix it .

@RCheesley
Copy link
Member

Hi @Joseph2001-braganza do you feel you can continue with this and address the feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants