Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new report data source 'Focus stats' #14279

Open
wants to merge 12 commits into
base: 5.x
Choose a base branch
from

Conversation

JonasLudwig1998
Copy link

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🟢
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR adds an extra report data source called 'Focus Stats'.

image

There one can select the columns: name, url, interaction, page hits, unique hits, description, focus type, style

image

The report is meant to show statistics for page hits and unique hits for both your focus item views and clicks.

image


📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Create some focus stats data by:
    1. Creating multiple focus items
    2. Adding focus items to a landing page
    3. Open the landing pages in different incognito browser windows multiple times to add some views / views+clicks
  3. Create a report with data source ‚focus stats‘ and select all columns
  4. Check if all the data in the report corresponds to your behavior from 2.3 (you can also check in your database via the tables focus, focus_stats, channel_url_trackables, page_redirects)

Copy link

@MadlenF MadlenF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described from user perspective.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.23%. Comparing base (dfa51f4) to head (2ae0a3c).
Report is 1 commits behind head on 5.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #14279      +/-   ##
============================================
+ Coverage     63.15%   63.23%   +0.08%     
- Complexity    34468    34569     +101     
============================================
  Files          2266     2271       +5     
  Lines        103129   103380     +251     
============================================
+ Hits          65130    65373     +243     
- Misses        37999    38007       +8     
Files with missing lines Coverage Δ
...uticFocusBundle/EventListener/ReportSubscriber.php 100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants