-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new report data source 'Focus stats' #14279
Open
JonasLudwig1998
wants to merge
12
commits into
mautic:5.x
Choose a base branch
from
JonasLudwig1998:add-focus-item-report
base: 5.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add new report data source 'Focus stats' #14279
JonasLudwig1998
wants to merge
12
commits into
mautic:5.x
from
JonasLudwig1998:add-focus-item-report
+316
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ging with mautic/mautic won't cause problems
…s and views for channel focus items are added to the report
…est and duplicate check for new fields
MadlenF
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described from user perspective.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #14279 +/- ##
============================================
+ Coverage 63.15% 63.23% +0.08%
- Complexity 34468 34569 +101
============================================
Files 2266 2271 +5
Lines 103129 103380 +251
============================================
+ Hits 65130 65373 +243
- Misses 37999 38007 +8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an extra report data source called 'Focus Stats'.
There one can select the columns: name, url, interaction, page hits, unique hits, description, focus type, style
The report is meant to show statistics for page hits and unique hits for both your focus item views and clicks.
📋 Steps to test this PR:
1. Creating multiple focus items
2. Adding focus items to a landing page
3. Open the landing pages in different incognito browser windows multiple times to add some views / views+clicks