Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins are not logging the security token #14277

Open
wants to merge 6 commits into
base: 5.x
Choose a base branch
from

Conversation

shinde-rahul
Copy link
Contributor

@shinde-rahul shinde-rahul commented Nov 21, 2024

Q A
Bug fix? (use the a.b branch) 🟢
New feature/enhancement? (use the a.x branch) 🔴
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🟢
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

Integrated plugins are logging the security. This PR hashes the token before logging.

Before After
Before Before

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Activate the hubspot plugin and add the Access token.
  3. Close and open the fubspot integration modal window.
  4. Find the logged data. The token is now hashed. This was not the case before

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.24%. Comparing base (dfa51f4) to head (682019e).
Report is 1 commits behind head on 5.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #14277      +/-   ##
============================================
+ Coverage     63.15%   63.24%   +0.09%     
- Complexity    34468    34567      +99     
============================================
  Files          2266     2270       +4     
  Lines        103129   103361     +232     
============================================
+ Hits          65130    65372     +242     
+ Misses        37999    37989      -10     
Files with missing lines Coverage Δ
...uginBundle/EventListener/IntegrationSubscriber.php 31.25% <100.00%> (+24.79%) ⬆️
app/bundles/PluginBundle/Helper/oAuthHelper.php 6.02% <100.00%> (+6.02%) ⬆️

... and 12 files with indirect coverage changes

---- 🚨 Try these New Features:

@shinde-rahul shinde-rahul marked this pull request as ready for review November 21, 2024 12:48
@shinde-rahul shinde-rahul added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging plugin Anything related to plugins labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs code-review-needed PR's that require a code review before merging plugin Anything related to plugins ready-to-test PR's that are ready to test
Projects
Status: 🦸🏻 Needs 2 tests
Development

Successfully merging this pull request may close these issues.

1 participant