[UI/UX] Toolbar page actions #14275
Open
[UI/UX] Toolbar page actions #14275
+1,471
−790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b6aa467.
commit 007b788 Merge: a3a97a1 f2791bf Author: Anderson, from Dropsolid <[email protected]> Date: Fri Oct 4 15:12:56 2024 -0300 Merge remote-tracking branch 'upstream/5.x' into ui-remove-search-help-from-list-toolbar commit a3a97a1 Merge: b1ec3d1 93db721 Author: Anderson, from Dropsolid <[email protected]> Date: Wed Sep 18 15:30:42 2024 -0300 Merge remote-tracking branch 'upstream/5.x' into ui-remove-search-help-from-list-toolbar commit b1ec3d1 Author: andersonjeccel <[email protected]> Date: Thu Jul 11 15:45:28 2024 -0300 searchHelp entries commit e6eac73 Author: andersonjeccel <[email protected]> Date: Thu Jul 11 15:39:22 2024 -0300 translations commit d9146e8 Author: andersonjeccel <[email protected]> Date: Thu Jul 11 15:38:43 2024 -0300 toolbar
This reverts commit 90c2e6f.
andersonjeccel
added
T1
|
@abhisekmazumdar some changes to structure made e2e tests fail :) |
|
I would expect, that the live view works like a toggle. But actually I don't know if it's on. |
|
Perfect, couldn't as for more. |
jos0405
approved these changes
Nov 21, 2024
jos0405
added
pending-test-confirmation
shinde-rahul
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Code changes LGTM!!!
Thanks, @andersonjeccel, for this facelift. I loved the new look.
shinde-rahul
added
code-review-passed
kuzmany
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR groups related elements together to follow UX best practices.
When working on a details page, it makes sense to have a page header containing actions for the current resource (e.g. Edit action, to edit the current form, for example).
Maybe not that much for a page that lists several resources for the same thing... In a first moment, you might look at the current state of our index pages and think that they look good.
but what if we add a widget to show a chart about your lead generation? what would be the "New" page action for, creating a contact or adding a new widget?
as we think about making the listing pages more attractive, is inevitable to consider adding content that creates a relationship with everything else you do in Mautic everyday
Placing the page actions on the toolbar specifically for listing pages aim to address this case, allowing us to keep developing content to make the tool get increasingly better without causing confusion to our users
📋 Steps to test this PR: