Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification message to include the reason #14216

Open
wants to merge 3 commits into
base: 5.x
Choose a base branch
from

Conversation

shinde-rahul
Copy link
Contributor

@shinde-rahul shinde-rahul commented Oct 22, 2024

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🔴
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🔴
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #14105

Description

Please see #14105


📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Create multiple imports, out of which a minimum of two should be in In-Progress status
  3. Execute the bin/console mautic:import and see the notification area.

PS. Creating import with In-Progress status is a challenge via UI.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.16%. Comparing base (6e0121a) to head (8bbc4b0).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #14216      +/-   ##
============================================
+ Coverage     63.15%   63.16%   +0.01%     
  Complexity    34462    34462              
============================================
  Files          2266     2266              
  Lines        103102   103102              
============================================
+ Hits          65109    65125      +16     
+ Misses        37993    37977      -16     
Files with missing lines Coverage Δ
app/bundles/LeadBundle/Model/ImportModel.php 87.64% <100.00%> (+4.24%) ⬆️

... and 2 files with indirect coverage changes

@shinde-rahul shinde-rahul marked this pull request as ready for review October 23, 2024 07:37
@shinde-rahul shinde-rahul added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging contacts Anything related to contacts import-export Anything related to importing and exporting hacktoberfest Issues that would be great for Hacktoberfest participants to work on labels Oct 23, 2024
@RCheesley RCheesley added the hacktoberfest-accepted PR's that have been accepted for the purposes of Hacktoberfest label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs code-review-needed PR's that require a code review before merging contacts Anything related to contacts hacktoberfest Issues that would be great for Hacktoberfest participants to work on hacktoberfest-accepted PR's that have been accepted for the purposes of Hacktoberfest import-export Anything related to importing and exporting ready-to-test PR's that are ready to test
Projects
Status: No status
Status: 🦸🏻 Needs 2 tests
Development

Successfully merging this pull request may close these issues.

Notification | Import failed. Reason: %reason%
2 participants