-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Docs explaining how to use the accordion component #200
base: 5.x
Are you sure you want to change the base?
Conversation
@RCheesley Could you please help with this issue? I’ve fixed the Vale error, but it seems a link is breaking, which is causing the build to fail. cc: @andersonjeccel |
@favour-chibueze it looks like https://docs.mautic.org/en/5.x/configuration/cron_jobs.html#tracking-script is no longer a valid link. This is because it was (rightly) moved out of the Cron Jobs section: https://docs.mautic.org/en/5.x/configuration/tracking_script.html. So we need a separate PR to fix that build failure in the link file. Can you do that? |
Here's the PR that fixes this |
Great, good to go then if you're happy with the PR changes @favour-chibueze and they render well. I haven't checked it yet myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some concerns about two settings files which I think don't relate to this PR - can you take a look?
@RCheesley It seems RTC |
Please fix the heading nesting:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The heading nesting is incorrect in this PR and it needs tweaking before it can be merged. Please see earlier comment.
This PR introduces documentation for the accordion component, addressing a critical gap in our UI toolkit. Without this, developers would struggle to implement accordions consistently, leading to inconsistent user experiences and increased development time.
Here I provide instructions on how to properly utilize the accordion component, including best practices.