Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Improved connection configuration #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erimatnor
Copy link

  • Add ability to set channel class (enables use of, e.g., EpollEventLoop)
  • Add option to set statement timeout in PostgreSQL

@evanbennett
Copy link

Would statementTimeout be better as an Option[Duration] defaulting to None, and then the SET statement_timeout query only gets sent if it is Some(...)?

Also, the Configuration ScalaDoc was not updated for the new arguments.

@erimatnor
Copy link
Author

@evanbennett Yes,the Option approach might be better since it means using the default database setting in case of None. I will fix that and the ScalaDocs.

@erimatnor
Copy link
Author

@evanbennett PR updated. One other thing is that I didn't put the new configuration options in the Configuration class at the end of the parameter list. Instead I opted to put them in their logical places (Netty-stuff together, timeouts together). This might be bad for compatibility in case someone creates a Configuration without named parameters. Opinions?

- Add ability to set channel class (enables use of, e.g., EpollEventLoop)
- Add option to set statement timeout in PostgreSQL
@mauricio
Copy link
Owner

mauricio commented Jul 8, 2016

@erimatnor do you mind including this for MySQL as well? http://mysqlserverteam.com/server-side-select-statement-timeouts/

Also, the option should come at the end since both of them use the same type and could get mixed if named parameters are not in use.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants