This repository has been archived by the owner on Dec 3, 2019. It is now read-only.
PostgreSQLConnection refactoring #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about the broken specs here? |
|
It looks like these changes break the Kerberos tests somehow. But for these tests do not work on master as well with the same errors. So I thought it was not problem of my changes. You told this tests should work on Postges 8 only? |
|
@antonzherdev I didn't forget about this, but I'm moving between countries now so live is a mess, I'll definitely check this stuff once I'm sorted out there. |
|
@mauricio No problem. There is no hurry:) |
|
2 years have left, any progress here? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring enables to process rows in different ways, not only in future.