-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pip installable #16
Open
algrs
wants to merge
59
commits into
mattloper:master
Choose a base branch
from
bodylabs:122_make_pip_installable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring in history from BL…
…et to any number between 1 and 3 (and is 3 by default). Conflicts: renderer.py
Without this, if you had two versions of opendr installed, for example one that you're working on and an old one in site-packages, they could import each other, leaveing you with potentially inconsistent code that can be really hard to debug.
…w badly we are failing
… tolerate lack of cython, and added normalization option to VertNormals.
Conflicts: Makefile __init__.py renderer.py setup.py test_depth_renderer.py test_renderer.py
This pulls in the changes from korper made to the old offscreen_pyrenderer by Paul in 7cd62887.
…hich will compute jacobian
that was in practice being applied to a ch.array (created in camera.unproject_depth_image for some unknown reason). 25x speedup.
This includes the fix for complaining about 'normalize' in VertNormals
* Catches BadZipFile and retries download once * Now also closes urllib2 connection when done
…0.74.0 (#5) * Fix setup.py * Correct version * Address code review * Use parse_requirements from pip * Fix setup
* Preinstall numpy and scipy as they are needed to compile other stuff * scipy.stats.nanmean has been deprecated since 0.15 * Fix some float-as-index bugs
Weirdly, github wants to include every commit ever in the diff... I can open the PR on bodylabs/opendr directly and then we can merge it up if that'd be an easier way to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to make opendr
pip install -e .
able in order to track down a test failure in core; fixed lint while I was at it. This is a huge diff, but most of it is minor lint changes. Look at commit 8eea8ab for the changes related to pip and the following commits for lint fixing. Tests are passing in circleci: https://circleci.com/gh/bodylabs/opendr/401