Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matches and nested APIs #119

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add matches and nested APIs #119

wants to merge 1 commit into from

Conversation

matthewp
Copy link
Owner

Closes #56

@HipsterBrown
Copy link
Contributor

This looks great! 👏 I also like the included nested helper for quickly creating child machines. 💯

Looks like the bundlesize just needs to be updated to get CI green. I wonder if it's possible to feed that bundle size data into the website, i.e. "Fast 1.48kb functional library for creating Finite State Machines"

@gkiely
Copy link
Contributor

gkiely commented Feb 1, 2023

@matthewp is there some additional work you would like to implement on this branch or is it able to be merged in?

If you'd like this merged, I'd be happy to address the conflicts and get it ready for review.

@matthewp
Copy link
Owner Author

matthewp commented Feb 1, 2023

@gkiely feel free to update the branch. I would like to take another look before we release it though. This might make a good 1.0 feature.

@matthewp
Copy link
Owner Author

matthewp commented Feb 2, 2023

This PR also needs docs before merging. And a changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out a better way for matching the current state
4 participants