-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content safety #5486
Content safety #5486
Conversation
Building app in separate branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified on test builds on Android and iOS (13.7 on iPad and 14.3 on iPhone 7) that the YouTube link opens the video as expected. LGTM.
Note: Created https://mattermost.atlassian.net/browse/MM-36688 for the issue.
Cherry pick is scheduled. |
Error trying doing the automated Cherry picking. Please do this manually
|
manual cherry-pick |
* add content safety check to avoid potential crashes * Fixes iOS YouTube video playback
Summary
This PR adds some safety checks around post message attachments and app bindings to prevent the app from crashing when
null
is present in the post metadata for some reason.Also includes a fix for YouTube video playback (for example this one https://www.youtube.com/watch?v=eWCXZIRm7iU&t=707). Fix taken from 0xced/XCDYouTubeKit#534
Release Note