Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml document separators to CRDs to make helm show crds valid #485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vasfed
Copy link

@Vasfed Vasfed commented Dec 26, 2024

Modern helm has command show crds to get CRDs from chart without untarring etc:

helm show crds mattermost/mattermost-operator

It concatenates files from crds/, thus currently produces invalid yaml for mattermost-operator (with keys redefinition).

Helm has a proposal to forcefully add separators, but it was not accepted for more than a year at the moment and it's not clear when and if it will be.

This PR makes helm's output valid and useable

@mattermost-build
Copy link
Contributor

Hello @Vasfed,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@Vasfed
Copy link
Author

Vasfed commented Dec 26, 2024

/check-cla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants