[GH-326] [GH-327] Add tests to detect templating errors in more common situations and fix #328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds tests to help identify templating errors by running
helm template
silently, and failing on errors. This also allows sensible default values to be defined (e.g.ingress.enabled=true
,presistence.enabled=true
andautoscaling.enabled=true
) for more comprehensive coverage.I attempted to implement this by using the latest version of chart-testing, however, the configuration options don't appear to work, and it could not effectively identify errors without supplying new
values.yaml
files.This PR also fixes ingress template errors in the
mattermost-chaos-engine
andmattermost-grafana
chart recently introduced by #322.Ticket Link
Fixes #326 and #327