Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version command #195

Closed
wants to merge 3 commits into from
Closed

Conversation

horpto
Copy link

@horpto horpto commented Mar 28, 2023

No description provided.

@sudo-suhas
Copy link
Collaborator

What problem is this fixing? The version command is working as expected:

mkdir -p /tmp/moq-v-test \
  && cd $_ \
  && wget -qO- https://github.com/matryer/moq/releases/download/v0.3.1/moq_0.3.1_macOS_arm64.tar.gz \
    | tar zxvf - --directory=. \
  && ./moq -version
x LICENSE
x README.md
x moq
moq version 0.3.1

It is printing the version as expected.

@breml
Copy link
Contributor

breml commented Mar 29, 2023

This was originally part of #193 and I suggested to extract it to a separate PR, but I did not check if it is working or not. To me, it looks like https://github.com/matryer/moq/blob/main/.goreleaser.yml#L15 is doing the right thing already.

@sudo-suhas sudo-suhas closed this Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants