Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

MessageComposerButtons: code cleanup, move buttons out of dropdown #8930

Closed
wants to merge 4 commits into from

Conversation

ckiee
Copy link
Contributor

@ckiee ckiee commented Jun 29, 2022

If we're in wide mode, we might away steal a bit more space from the text input to save a click for users.

There's 3 options in this PR:

  1. First commit only (just a code refactor; same as before this PR)
    Screen Shot 2022-06-29 at 06 23 27
  2. Second commit
    Screen Shot 2022-06-29 at 06 22 18
  3. All commits
    Screen Shot 2022-06-29 at 06 22 29

Opinions? I think #2 is too overloaded.

Notes: TBD
Type: enhancement


Here's what your changelog entry will look like:

✨ Features

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jun 29, 2022
@luixxiul
Copy link
Contributor

luixxiul commented Jun 29, 2022

@ckiee It looks to me that you're working on the 'new' message composer which was redacted recently due to a lot of regressions... Is it intentional? Or does it not really matter here?

@ckiee
Copy link
Contributor Author

ckiee commented Jun 29, 2022

@ckiee It looks to me that you're working on the 'new' message composer which was redacted recently due to a lot of regressions. Is it intentional?

Oops. I hadn't pulled on develop in a few days. Will rebase.

(Also, I love the use of redacted in "which was redacted recently". You are immersed in the Matrix.)

@github-actions github-actions bot added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jun 29, 2022
@t3chguy t3chguy requested a review from a team August 3, 2023 12:46
@langleyd langleyd closed this Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants