This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Allow to reuse sounds for custom notifications #6002
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses one point in element-hq/element-web#9687
I added a List of already uploaded Sounds, including an option for the default and an option to upload a new Sound.
I changed the behavior of the reset Button to reset the selection to the previously saved option, instead of setting the sound to the default (This is now an option in the list instead)
Here's what your changelog entry will look like:
✨ Features