Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Getting Started and Customizing the look and feel. #21

Merged
merged 5 commits into from
Apr 18, 2018

Conversation

biophyser
Copy link
Contributor

I added a line in custom_look to change the html theme to address the root cause of issue #16. I also updated the screenshots on the getting_started and custom_look pages. Also got a doctest error caused by #20 so I changed it back to get the build to work.

Jeremy Anderson added 3 commits April 11, 2018 09:20
… looks like the screenshot. Updated the screenshot to what it will look like for users.
@phobson
Copy link
Member

phobson commented Apr 17, 2018

Thanks for the PR. Rather than creating new files ("new_basic_screenshot") can you just rewrite the old files? They won't be "new" for very long.

@biophyser
Copy link
Contributor Author

Sorry, missed that one.

@tacaswell
Copy link
Member

@biophyser what version of numpy are you using? The change to the spacing in reprs is a change in a recent version of numpy, would rather leave it to pass with newer version rather than old.

@biophyser
Copy link
Contributor Author

Yep, you're totally right. I was using numpy 1.13 and doctest failed with numpy 1.14. I reversed the changes in ipython_directive.rst

@tacaswell
Copy link
Member

@biophyser Sorry, I did not follow your last comment all the way. I am correct that the way it is now (no change) works with np.1.14?

@biophyser
Copy link
Contributor Author

Sorry for the confusion @tacaswell. The changes I originally made worked with np 1.13 but not with np 1.14. I pushed a commit earlier today that reversed the changes in the ipython_directive file so it is compatible with np 1.14 now.

@tacaswell tacaswell merged commit 7d6c4cd into matplotlib:master Apr 18, 2018
@tacaswell
Copy link
Member

Thanks @biophyser !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants