feat: dockview accessibility #701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 658e56d:
|
iammola
commented
Aug 28, 2024
Comment on lines
+81
to
+86
| const randomId = Math.random().toString(36).slice(2); | ||
|
|
||
| this.tabComponentElId = | ||
| options.tabComponentElId ?? `tab-${id}-${randomId}`; | ||
| this.componentElId = | ||
| options.componentElId ?? `tab-panel-${id}-${randomId}`; |
There was a problem hiding this comment.
Is this acceptable for creating the fallback IDs? Using Math.random?
iammola
force-pushed
the
tab-accessibility
branch
from
f3c6742
to
23a7bbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to improve the accessibility of the tabs and their panels.
Used the example in https://www.w3.org/WAI/ARIA/apg/patterns/tabs/examples/tabs-automatic/ essentially.
I started working on this yesterday because I need it for my project, and have just noticed the #700 also requests for this.