Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make sure panel vue component be child of DockViewVue component #669

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chuyuandu
Copy link

In vue3 project
register multi Vue3 panel component
component instance is not child of DockViewVue instance, so provide/inject feature lost
use teleport to render component to target, keep vue component instance tree structure.

Copy link

codesandbox-ci bot commented Jul 31, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 38323d9:

Sandbox Source
customheader-dockview Configuration
dockview-app Configuration
editor-gridview Configuration
events-dockview Configuration
externaldnd-dockview Configuration
fullwidthtab-dockview Configuration
iframe-dockview Configuration
keyboard-dockview Configuration
lockedgroup-dockview Configuration
nativeapp-dockview Configuration
nested-dockview Configuration
rendering-dockview Configuration

@mathuo mathuo linked an issue Aug 1, 2024 that may be closed by this pull request
@mathuo
Copy link
Owner

mathuo commented Aug 5, 2024

I would need to check this logic at some point but the changes in dockviewComponent.ts - I don't think they are required?

@chuyuandu
Copy link
Author

I would need to check this logic at some point but the changes in dockviewComponent.ts - I don't think they are required?

when i use teleport to render panel component,
the rightHeaderActionsComponents's props revieve params, params.group is a proxy object
some logic will fail using ===, so i change to compare the group id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vu3 inject/provides not propagated to panels
2 participants