Merge pull request #4076 from mathesar-foundation/todo_beta_code_comm…

…ents Remove TODO_BETA code comments
mathesar-foundation · Dec 24, 2024 · 9840e61 · 9840e61
2 parents cf3ddd4 + 36bce93
commit 9840e61
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 28 deletions.
diff --git a/mathesar_ui/src/components/breadcrumb/SchemaSelector.svelte b/mathesar_ui/src/components/breadcrumb/SchemaSelector.svelte
@@ -19,7 +19,7 @@
   function makeBreadcrumbSelectorItem(schema: Schema): BreadcrumbSelectorEntry {
     return {
       type: 'simple',
-      // TODO_BETA: Make label a store
+      // TODO: Make label a store
       label: get(schema.name),
       href: getSchemaPageUrl(database.id, schema.oid),
       icon: iconSchema,

diff --git a/mathesar_ui/src/contexts/DatabaseSettingsRouteContext.ts b/mathesar_ui/src/contexts/DatabaseSettingsRouteContext.ts
@@ -120,7 +120,7 @@ export class DatabaseSettingsRouteContext {
      * When a configured role is removed from the Role Configuration page,
      * Collaborators list needs to be reset, since the drop statement cascades.
      *
-     * TODO_BETA: Discuss on whether we should cascade or throw error?
+     * TODO: Discuss on whether we should cascade or throw error?
      */
     this.collaborators.reset();
   }

diff --git a/mathesar_ui/src/pages/database/DatabasePageWrapper.svelte b/mathesar_ui/src/pages/database/DatabasePageWrapper.svelte
@@ -144,7 +144,10 @@
           <ButtonMenuItem icon={iconDeleteMajor} on:click={disconnectDatabase}>
             {$_('disconnect_database')}
           </ButtonMenuItem>
-          <!-- TODO_BETA: Allow dropping databases -->
+          <!--
+            TODO: Allow dropping databases
+            https://github.com/mathesar-foundation/mathesar/issues/3862
+          -->
           <!-- {#if isDatabaseInInternalServer}
             <ButtonMenuItem
               icon={iconDeleteMajor}

diff --git a/mathesar_ui/src/stores/table-data/columns.ts b/mathesar_ui/src/stores/table-data/columns.ts
@@ -74,10 +74,6 @@ export class ColumnsDataStore extends EventHandler<{
     try {
       this.fetchStatus.set({ state: 'processing' });
       this.promise?.cancel();
-      // TODO_BETA: For some reason `...this.shareConsumer?.getQueryParams()`
-      // was getting passed into the API call when it was REST. I don't know
-      // why. We need to figure out if this is necessary to replicate for the
-      // RPC call.
       this.promise = api.columns
         .list_with_metadata({ ...this.apiContext })
         .run();

diff --git a/mathesar_ui/src/stores/table-data/constraints.ts b/mathesar_ui/src/stores/table-data/constraints.ts
@@ -127,17 +127,8 @@ export class ConstraintsDataStore implements Writable<ConstraintsData> {
 
     try {
       this.promise?.cancel();
-
-      // TODO_BETA Do we need shareConsumer here? Previously we had been
-      // passing:
-      //
-      // ```
-      // ...this.shareConsumer?.getQueryParams()
-      // ```
       this.promise = api.constraints.list(this.apiContext).run();
-
       const constraints = await this.promise;
-
       const storeData: ConstraintsData = { state: States.Done, constraints };
       this.set(storeData);
       return storeData;

diff --git a/mathesar_ui/src/stores/table-data/records.ts b/mathesar_ui/src/stores/table-data/records.ts
@@ -401,8 +401,6 @@ export class RecordsData {
           .withEntries(contextualFilterEntries)
           .recordsRequestParams(),
         return_record_summaries: this.loadIntrinsicRecordSummaries,
-        // TODO_BETA Do we need shareConsumer here? Previously we had been
-        // passing `...this.shareConsumer?.getQueryParams()`
       };
 
       const fuzzySearchParams = params.searchFuzzy.getSearchParams();

diff --git a/mathesar_ui/src/systems/data-explorer/utils.ts b/mathesar_ui/src/systems/data-explorer/utils.ts
@@ -489,15 +489,9 @@ export function speculateColumnMetaData({
               type_options:
                 aggregation.function === 'distinct_aggregate_to_array'
                   ? {
-                      // TODO_BETA: Ask Pavish.
-                      //
-                      // `Column['type_options']` was previously typed loosely
-                      // as `Record<string, unknown> | null`. Now it's more
-                      // strict and it doesn't have a `type` property.
-                      //
-                      // type:
-                      //   updatedColumnsMetaData.get(aggregation.inputAlias)
-                      //     ?.column.type ?? 'unknown',
+                      item_type:
+                        updatedColumnsMetaData.get(aggregation.inputAlias)
+                          ?.column.type ?? 'unknown',
                     }
                   : null,
               metadata: null,

diff --git a/mathesar_ui/src/systems/table-view/row/RowCell.svelte b/mathesar_ui/src/systems/table-view/row/RowCell.svelte
@@ -71,7 +71,7 @@
   $: hasError = !!errors.length;
   $: isProcessing = modificationStatus?.state === 'processing';
   $: isTableEditable = currentRoleTablePrivileges.has('UPDATE');
-  // TODO_BETA: Handle case where INSERT is allowed, but UPDATE isn't
+  // TODO: Handle case where INSERT is allowed, but UPDATE isn't
   // i.e. row is a placeholder row and record isn't saved yet
   $: isEditable =
     isTableEditable &&