Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gettext: fix GEN org.mate.system-monitor.gschema.xml #186

Closed
wants to merge 1 commit into from

Conversation

rbuj
Copy link
Contributor

@rbuj rbuj commented Jan 22, 2020

Closes #185

@cwendling
Copy link
Member

Does that fix #185?

@rbuj
Copy link
Contributor Author

rbuj commented Jan 22, 2020

Does that fix #185?

Yes, I ran this test:

$ tx pull -a -f && ./autogen.sh --prefix=/usr && make && sudo make install

@raveit65
Copy link
Member

raveit65 commented Jan 22, 2020

@rbuj @cwendling
I think we need to

  1. revert 9bf5095 on master
  2. merge this PR
  3. push a new resource file to transifex
  4. Wait a while an pull new translations from transifex.
  5. See, if building works

Right?

Edit: you post was faster

@rbuj
Copy link
Contributor Author

rbuj commented Jan 22, 2020

WIP

@raveit65
Copy link
Member

raveit65 commented Jan 22, 2020

Weird,
without pushing a new resource file to transifex the build failed here on this branch.

tx pull -a -f && ./autogen.sh && make

be.po:888: 'msgstr' is not a valid C format string, unlike 'msgid'. Reason: The character that terminates the directive number 1 is not a valid conversion specifier.
be.po:893: 'msgstr' is not a valid C format string, unlike 'msgid'. Reason: The character that terminates the directive number 1 is not a valid conversion specifier.
/usr/bin/msgfmt: found 2 fatal errors

How did this work for you?

@raveit65
Copy link
Member

A new created .pot file on this branch is equal to the one on master.
So, this seems to be not necessary.

@rbuj
Copy link
Contributor Author

rbuj commented Jan 22, 2020

It doesn't fix the build, and GSETTINGS_RULES macro should not be removed. (compiled schema)
https://gitlab.gnome.org/GNOME/glib/blob/master/m4macros/gsettings.m4

@rbuj rbuj closed this Jan 22, 2020
@rbuj rbuj deleted the fix-gen-gschemal-xml branch January 22, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build issue with a lot of languages
3 participants