Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll interface tabs with mouse wheel #172

Closed
wants to merge 1 commit into from

Conversation

tamplan
Copy link
Contributor

@tamplan tamplan commented Jun 30, 2019

Fixes #166

Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, though the scroll action on the tabs is very, very fast. Anyone not able to stop on a tab though can click on it. Is it possible to use the scroll delta in the events
https://developer.gnome.org/gdk3/stable/gdk3-Event-Structures.html#GdkEventScroll
to slow this down, or is that simply too much complexity for a minor issue? There are four tabs here, the inner two are passed by very fast at least on my setup. Not blocking merge over this, not sure if setting a minimum delta here is practical or not anyway.

@lukefromdc lukefromdc requested a review from a team July 2, 2019 06:12
@tamplan
Copy link
Contributor Author

tamplan commented Jul 2, 2019

We could perhaps first fix the issue mentioned yet and then study a better solution to give navigation more slowly?

@sc0w
Copy link
Member

sc0w commented Jul 7, 2019

it seems to work lagged here, and some tabs are ignored sometimes, see the video:

out-73.ogv.zip

@tamplan
Copy link
Contributor Author

tamplan commented Jul 7, 2019

I re-test the application and confirm the behaviour.
It's perhaps better to not implement tab navigation with mouse wheel in this case and reject this PR for the moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to scroll interface tabs with mouse wheel on mate-system-monitor
4 participants