-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plotting functions #244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues for plotting.
…dTanimotoScores and CalculateScoresBetweenAllIonmodes.py
… to use CalculateScoresBetweenAllIonmodes
…weenAllIonmodes.py
…update_plotting_functions
…g save load combi)
ms2deepscore/validation_loss_calculation/PredictionsAndTanimotoScores.py
Outdated
Show resolved
Hide resolved
florian-huber
approved these changes
Oct 28, 2024
This was referenced Oct 29, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started with adding functions for creating the heatmap plots and average prediction per bin plot, but resulted in a large refactoring of the code.
Before we had multiple places in the code where predictions were made, tanimoto scores calculated and losses calculated. These steps are often complex/confusing, since they both have to be the average per inchikey pair (instead of spectrum pair) and the average per bin. Having many different places were these calculations were made and different formats required for plotting, made the code hard to interpret.
This PR is an attempt to reformat the code to make it more harmonized.
@florian-huber
I still had the following questions/choices made that I would like to have your input on: