Merge pull request #39 from mashabow/ts-github-actions

GitHub Actions 上で型検査する
mashabow · Sep 24, 2021 · 9ce5a78 · 9ce5a78
2 parents 69cac77 + fd51a1f
commit 9ce5a78
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 211 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -15,6 +15,10 @@ jobs:
           node-version: "14.x"
       - run: npm ci
       - run: npm run lint:ci
+      - name: Type check
+        uses: gozala/[email protected]
+        with:
+          project: functions/tsconfig.json
       - name: Create serviceAccountKey.json for online testing
         run: echo "$SERVICE_ACCOUNT_KEY_JSON" > ../serviceAccountKey.json
         env:

diff --git a/functions/package-lock.json b/functions/package-lock.json
diff --git a/functions/package.json b/functions/package.json
@@ -9,6 +9,7 @@
     "logs": "firebase functions:log",
     "lint": "eslint --format codeframe --ext .js,.jsx,.ts,.tsx .",
     "lint:ci": "npm run lint -- --max-warnings=0",
+    "type": "tsc --noEmit",
     "test": "jest",
     "test:ci": "npm run test -- --ci"
   },
@@ -26,7 +27,6 @@
   },
   "devDependencies": {
     "@slack-wrench/jest-mock-web-client": "^1.2.0",
-    "@types/jest": "^26.0.9",
     "@types/supertest": "^2.0.10",
     "@typescript-eslint/eslint-plugin": "^3.8.0",
     "@typescript-eslint/parser": "^3.8.0",

diff --git a/functions/src/__tests__/index.test.ts b/functions/src/__tests__/index.test.ts
@@ -1,4 +1,12 @@
-import { describe, it, expect } from "@jest/globals";
+import {
+  afterAll,
+  beforeEach,
+  afterEach,
+  describe,
+  it,
+  expect,
+  jest,
+} from "@jest/globals";
 import {
   MockedWebClient,
   MockWebClient,

diff --git a/functions/src/model/__tests__/rotation.test.ts b/functions/src/model/__tests__/rotation.test.ts
@@ -1,4 +1,4 @@
-import { describe, it, expect } from "@jest/globals";
+import { describe, it, expect, jest } from "@jest/globals";
 import { Rotation } from "../rotation";
 
 describe("Rotation", () => {