fix int format in search results #479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urwrstkn8mare
added a commit
to urwrstkn8mare/mas
that referenced
this pull request
Apr 16, 2023
1 task
|
still relevant bug |
rgoldberg
reviewed
Sep 5, 2024
| @@ -26,9 +26,9 @@ enum SearchResultFormatter { | |||
| let price = result.price ?? 0.0 | |||
|
|
|||
| if includePrice { | |||
| output += String(format: "%12d %@ $%5.2f (%@)\n", appId, appName, price, version) | |||
| output += String(format: "%12ld %@ $%5.2f (%@)\n", appId, appName, price, version) | |||
There was a problem hiding this comment.
Please change from %12ld to %12lu (signed to unsigned)
There was a problem hiding this comment.
The ld format specifier matches what is being printed -- the trackId member of the SearchResult struct, which currently has type Int, not UInt.
Presumably the API does not actually return negative trackId's, so it probably makes sense to change both the type and the format specifier. But I'm not sure about changing one and not the other?
This was referenced Sep 5, 2024
Draft
Since `trackId` is an `Int` and can be a number greater than `Int32.max`, it should be printed with the `%ld` format specifier [1]. [1]: https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/Strings/Articles/formatSpecifiers.html#//apple_ref/doc/uid/TP40004265-SW5
algorythmic
force-pushed
the
int-size
branch
from
56bad37
to
171c88d
Compare
xyzzy-plugh-plover
added a commit
to xyzzy-plugh-plover/mas
that referenced
this pull request
Sep 11, 2024
Supersede mas-cli#479 Fix mas-cli#478 Signed-off-by: xyzzy-plugh-plover <[email protected]>
|
Closing since PR #535 includes the small fix here within a more comprehensive fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
trackIdis anIntand can be a number greater thanInt32.max, it should be printed with the%ldformat specifier.Fixes #478