Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental Docker log follower implementation #125

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tjb346
Copy link

@tjb346 tjb346 commented May 12, 2020

I saw this issue was marked as help wanted here #67 and decided to take a stab at it since I need this feature too.

The instructions on how to use are in the README, but basically you enable experimental features, mount the host's docker socket to the container, and add the following to the config:

namespace "nginx" {
  source {
    docker {
      container = "nginx_container_name"
    }

    // ...
  }
}

@codeclimate
Copy link

codeclimate bot commented May 12, 2020

Code Climate has analyzed commit a00de11 and detected 0 issues on this pull request.

View more on Code Climate.

@martin-helmich
Copy link
Owner

Oh, wow. 😍 Thanks for the contribution. 👍 I'll take a look shortly.

@selckin
Copy link

selckin commented Jun 10, 2020

Tried to use this with https://github.com/nginx-proxy/nginx-proxy, but nginx-proxy prepends "nginx.1 |" to the log messages, don't see a way configure the 'format' to include/ignore those, would love to hear if it i possible

@helmich-bot
Copy link
Collaborator

There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

@zidagar
Copy link

zidagar commented Nov 4, 2020

I've tested this feature and works correctly.
Do you think to reopen the pull request and merge it in the next release?

@jasenmh
Copy link

jasenmh commented Dec 3, 2020

I could use this as well. Is there any other interest in re-opening this PR?

@martin-helmich
Copy link
Owner

Re-opening for now. I still remember wanting to test some edge cases on this, but then I lost track of this one... I'll give it another look shortly.

@helmich-bot
Copy link
Collaborator

There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

@helmich-bot helmich-bot added stale and removed stale labels Jan 13, 2021
@helmich-bot
Copy link
Collaborator

There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

@giom-l
Copy link

giom-l commented Feb 15, 2023

This would be extremely helpful !
Any chance to have it reviewed & merged soon ?

zubovyuri pushed a commit to zubovyuri/prometheus-nginxlog-exporter that referenced this pull request Nov 2, 2024
…the original repository); updated dependencies and upgraded Go version to 1.23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants