Fix DateInput and DateTimeInput Do Not Handle Temporary Values Correctly #9543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arimet
force-pushed
the
fix/dateInput
branch
from
355d240
to
f6e2760
Compare
djhi
requested changes
Jan 4, 2024
slax57
requested changes
Jan 4, 2024
| } | ||
| }, [setRenderCount, parse, field]); | ||
|
|
||
| const { onBlur: onBlurFromField } = field; |
There was a problem hiding this comment.
Why have a different logic for onBlur and onFocus?
There was a problem hiding this comment.
react-hook-form only handle onBlur not onFocus and it will call any custom onBlur provided
| const renderHelperText = | ||
| helperText !== false || ((isTouched || isSubmitted) && invalid); | ||
|
|
||
| const { ref, name } = field; | ||
|
|
||
| console.log('field', field); |
| @@ -133,7 +211,8 @@ const getStringFromDate = (value: string | Date) => { | |||
| // null, undefined and empty string values should not go through dateFormatter | |||
| // otherwise, it returns undefined and will make the input an uncontrolled one. | |||
| if (value == null || value === '') { | |||
| return ''; | |||
| console.log('toto'); | |||
| return ( | ||
| <TextField | ||
| id={id} | ||
| {...field} |
There was a problem hiding this comment.
Because the input is fully controlled locally now
|
I'm afraid you brought a regression to the Capture.video.2024-01-04.11.52.30.mp4 |
djhi
changed the title
djhi
changed the title
adguernier
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9330
The final implementation works in all tested browsers and handle reset correctly. However,
requiredvalidation won't work when the form mode is set toonChange. The validation message will only be displayed when the input is blurred.