Increase write capacity with --overwrite #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlimaloureiro
changed the title
sdesalas
reviewed
Apr 25, 2017
| if (error || !data) { | ||
| return this.emit('error', 'Fatal Error. Failed to update table. ' + error); | ||
| } | ||
| }).bind(this)); | ||
| setTimeout(dynamodb.describeTable.bind(dynamodb, { TableName: this.options.table }, this._checkTableReady.bind(this)), 1000); |
There was a problem hiding this comment.
Looks good to me. I would have moved the dynamodb.describeTable() call inside .updateTable() callback but it should work the same either way. 👍
There was a problem hiding this comment.
yes it's working, would also work the same way. Do you want me to change?
There was a problem hiding this comment.
No I think its fine dude. All good. 👍
Only downer might be that the repo owner has somehow lost access, and I dont have write access to merge these changes myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not being able to increase write capacity when using -c with --overwrite. This pr fix this issue.
Tested against mid size tables, working fine