Add Psalm #74
Add Psalm #74
Conversation
| { | ||
| array_pop($context[$key]); | ||
| } | ||
|
|
||
| /** | ||
| * @inheritdoc | ||
| */ | ||
| public function map($source, string $destinationClass, array $context = []) | ||
| public function map($source, string $targetClass, array $context = []) |
There was a problem hiding this comment.
Those renames are probably due to PHP 8 named arguments.
| @@ -15,9 +15,11 @@ interface MapperInterface | |||
| * Maps an object to an instance of class $to, provided a mapping is | |||
| * configured. | |||
| * | |||
| * @template T of object | |||
There was a problem hiding this comment.
These templates are the main improvements for the end user.
| @@ -10,14 +10,14 @@ | |||
| interface PropertyReaderInterface | |||
| { | |||
| /** | |||
| * @param $object | |||
| * @param object|array $object | |||
There was a problem hiding this comment.
This was added to be more correct, but the ArrayPropertyReader breaks the Liskov principle... What can we do?
|
Travis reporting doesn't seem to work, but the build seems green: https://travis-ci.org/github/mark-gerarts/automapper-plus/builds/762590792 I would suggest to migrate away from Travis though: it already reports a forced migration to the .com unified infra I'll try to draft up a separate PR to move to GitHub Actions. [EDIT] Done #75, but depending on which gets merged first I'll need to migrate the Psalm CI job too. |
Fixes #72.