feat: apply pytest rewrites for better testing #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Cool! Thoughts on exposing the interface to this error type? edit: looking at it, probably better in a followup PR if cuing off cell name |
akshayka
approved these changes
Dec 26, 2024
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.8-dev6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merry merry 🎄
Slight improvement on pytest errors, by manually running pytest's assertion rewrite magic. So that takes us from this:
to this
Also a little fun- this rewrite can be applied in general and shown in editor.
Not sure the overhead this might have- so not sure about setting it generally, but could set
test_rewrite=Trueif the cell name starts withtest_. Wanted to run this by you all first@akshayka OR @mscolnick