chore: use polars instead of pandas in examples #3289
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akshayka
commented
Dec 24, 2024
akshayka
commented
- Migrate the SQL examples to use Polars.
- Can merge when polars in pyodide is supported
* Migrate the SQL examples to use Polars.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Light2Dark
reviewed
Dec 25, 2024
Comment on lines
+6
to
+7
| # "polars==1.18.0", | ||
| # "pyarrow==18.1.0", |
There was a problem hiding this comment.
hey @akshayka , may want to consider "polars[pyarrow]>=1.18.0"
https://duckdb.org/docs/guides/python/polars.html
There was a problem hiding this comment.
Thanks! Will keep this in mind for the future. I think serializing both accomplishes the same thing?
There was a problem hiding this comment.
yes it does. Maybe just a small thing for future maintenance since we don't need to update the pyarrow version. But yeah it's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.