improvement: handle pl.Duration #3274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comment on lines
223
to
230
| } | ||
| return ColumnSummary( | ||
| total=total, | ||
| nulls=col.null_count(), | ||
| min=str(unit_map["us"]().min()) + "μs", | ||
| max=str(unit_map["us"]().max()) + "μs", | ||
| mean=str(unit_map["us"]().mean()) + "μs", | ||
| ) |
There was a problem hiding this comment.
it might be worth factoring out the total_* call, so it doesn't get recalculated?
duration = unit_map["us"]()
return ColumnSummary(
total=total,
nulls=col.null_count(),
min=str(duration.min()) + "μs",
max=str(duration.max()) + "μs",
mean=str(duration.mean()) + "μs",
)
akshayka
previously approved these changes
Dec 22, 2024
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.7-dev27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3267
This handles narwhals and polars Duration types, by treating them as
floatsand not temporal. We differ in the that we don't show the units for each entry (just at the top).For pandas, we treat them as strings (with the same formatting as their plain HTML)