-
-
Notifications
You must be signed in to change notification settings - Fork 72
Fixes #14 and #26 and #38 #35
base: master
Are you sure you want to change the base?
Conversation
I tested this in my little environment but please test it as well. |
For the love of God please merge this so I won't have to rely on my own fork. |
Seems like the author of this package has abandoned it. 😔 |
Do you know of any alternatives I can use for now..? I need a FAB like this one. |
I haven't looked for alternatives, I simply consumed the code into my project. You can see my fix in my patch fork. |
@MrCsabaToth If you take over this package and release to pub.dev I would definitely use & help you to maintain it. What do you think? |
I will be happy to help maintain and keep improving it as well... ❤️ |
I'm thinking about it. I'm looking at the pub.dev entry https://pub.dev/packages/fab_circular_menu and the link to this repository is removed. Publisher unverified. |
Using WidgetsBindingObserver's didChangeMetrics call _calculateProps and close. I haven't tried what this does if the app is resized in a split screen mode, but this is certainly needed for rotation.
Regarding #14: swapping the
OverflowBox
and theTranslation
+ scale transformation seems to help.Regarding #26: we just need to multiply the margin values by -1 or 1 based on where the menu is. Those factors are already available in the
_directionX
and_directionY
variables.Regarding #38: using
WidgetsBindingObserver
'sdidChangeMetrics
callback we call_calculateProps()
and alsoclose()
if the menu is open.