Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker registry credentials #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mprzysucha
Copy link

No description provided.

@marcus-drake
Copy link
Owner

Thanks @mprzysucha !

I have looked into this PR now. I'm questioning if this should be added to the plugin.
Would it be equivalent to run docker login -u {user} -p {password} {url} in a shell before sbt is started?
Or that it runs as a dependency task to the dockerBuildAndPush or dockerPush tasks?
Something like:

scala.sys.process.Process(Seq("docker", "login", ...)).run().exitValue()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants