Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editorconfig #13

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Add editorconfig #13

merged 2 commits into from
Oct 14, 2024

Conversation

thaugdahl
Copy link
Contributor

Self-explanatory PR :)

@thaugdahl thaugdahl requested a review from a team as a code owner October 14, 2024 07:55
Copy link
Member

@mscuttari mscuttari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not contrary to the addition of .editorconfig, because ClangFormat indeed does not to go beyond C / C++ source files. However:

  1. Having a capture-all section like the one present in the proposed file would lead to a duplicate configuration to be maintained coherent with respect to the LLVM styling guidelines.
  2. Some parts of the code are explicitly marked as to be ignored through the clang-format on/off comments. Some IDEs would ignore the ClangFormat entirely if an .editorconfig file is found, thus linting the code in an undesired way.

For these reasons I would prefer only the Python, CMake, and Makefile configurations to be there, letting ClangFormat to be the choice for C / C++ files.

By the way, it is not super clear to me why the Makefile configuration requests for tabs instead of whitespaces, like the rest of the project, but this may just be something beyond my knowledge.

@mscuttari
Copy link
Member

/fast-forward

@github-actions github-actions bot merged commit 10fc466 into master Oct 14, 2024
4 checks passed
@github-actions github-actions bot deleted the thaugdahl/editorconfig branch October 14, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants