Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job runner timeout option #40

Merged
merged 3 commits into from
May 4, 2024
Merged

Add job runner timeout option #40

merged 3 commits into from
May 4, 2024

Conversation

markuswustenberg
Copy link
Member

Otherwise, the underlying queue could have a much smaller timeout, and the runner wouldn't work properly.

Also:

  • Remove the done channel, we can just use jobCtx directly.
  • Some more doc comments.
  • Add logging before job run.
  • Add a test for the extension.

Otherwise, the underlying queue could have a much smaller timeout, and the runner wouldn't work properly.

Also:
- Remove the `done` channel, we can just use `jobCtx` directly.
- Some more doc comments.
- Add logging before job run.
- Add a test for the extension.
Copy link

codecov bot commented May 4, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.30%. Comparing base (95eb0b8) to head (3bc7f69).

❗ Current head 3bc7f69 differs from pull request most recent head c0f1701. Consider uploading reports for the commit c0f1701 to get more accurate results

Files Patch % Lines
jobs/runner.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   89.47%   89.30%   -0.17%     
==========================================
  Files           3        3              
  Lines         342      346       +4     
==========================================
+ Hits          306      309       +3     
- Misses         27       28       +1     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markuswustenberg markuswustenberg enabled auto-merge (squash) May 4, 2024 11:11
@markuswustenberg markuswustenberg merged commit 6de7171 into main May 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant