-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style Development for unpublished, or private or local styles #954
base: main
Are you sure you want to change the base?
Conversation
I don't think this is the right approach to this project. |
This documentation enhancement for Local Style Development also works for private, non-production styles. This PR shows others how to use this idea. Useful for Private or Local style developmentPrivate Styles
Local Styles
Our case
|
@HarelM — There were four use cases in this PR (private or non-published styles, documentation on how to, and a team's own copy of Maputnik) I didn't realize it when I first approached this idea, but hopefully some teams will find use of this. |
For running a local server, you can use Bottom line, I don't see how this helps anyone, sorry, I might be missing on what the problem statement or the relevant use cases... |
I usually do my style development opening Maputnik from maplibre.org in my browser and opening a file located on my PC. Using this approach there is no need to:
and I can run as many instances of Maputnik as I like, each in a separate tab. I think the word "Upload", mentioned several times in the "Open" pane, is incorrect and misleading. It should be rewritten as "Open" or "Load" The README.md says that when using Maputnik in the browser no data leaves the local computer:
As far as I understand when a style is opened (so-called "Uploaded") from a local file by the browser, it does not get "uploaded" anywhere. The browser's developer console (F12) supports this understanding. Therefore, there is no risk of an Intellectual Property leak. Is my understanding correct, @HarelM? In my opinion, if a new "Local Style Development" section is added to README.md, it had better describe the simpler use of the Open/Upload approach. |
Yes, there's no data sent anywhere as far as I know. The uploaded style is kept in the local storage of the browser. |
Launch Checklist
CHANGELOG.md
under the## main
section.updated README with a description on how to test & use this feature