Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only non-send futures #77

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

maxammann
Copy link
Collaborator

Async Rust is a mess.

💻 Examples

🚨 Test instructions

✔️ PR Todo

  • Included links to related issues/PRs

@maxammann maxammann marked this pull request as ready for review May 9, 2022 15:23
@maxammann
Copy link
Collaborator Author

I think input from a rust expert would be nice here...

@maxammann maxammann requested review from nyurik and ka7eh May 9, 2022 15:33
# Conflicts:
#	maplibre/Cargo.toml
#	maplibre/src/io/scheduler.rs
#	maplibre/src/io/source_client.rs
#	maplibre/src/platform/noweb/http_client.rs
#	maplibre/src/platform/noweb/schedule_method.rs
@maxammann maxammann force-pushed the main branch 3 times, most recently from 8c5d8ee to 4dbd47b Compare June 3, 2022 09:54
@maxammann maxammann changed the title Use only non-send futures Postphoned until needed: Use only non-send futures Nov 12, 2022
@maxammann maxammann changed the title Postphoned until needed: Use only non-send futures Postponed: Use only non-send futures Nov 19, 2022
@maxammann maxammann added the pr-postponed Postponed PR, which is not needed right now but might be needed (contains valuable information) label Nov 19, 2022
nyurik
nyurik previously approved these changes Nov 27, 2022
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Have you considered to use the nightly async trait feature?

# Conflicts:
#	maplibre/Cargo.toml
#	maplibre/src/io/scheduler.rs
#	maplibre/src/io/source_client.rs
#	maplibre/src/platform/noweb/http_client.rs
#	maplibre/src/platform/noweb/schedule_method.rs
#	web/Cargo.toml
@maxammann maxammann changed the title Postponed: Use only non-send futures Use only non-send futures Oct 20, 2023
@maxammann maxammann removed the pr-postponed Postponed PR, which is not needed right now but might be needed (contains valuable information) label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants