Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate MapView to react function components #408

Merged
merged 35 commits into from
Jul 12, 2024
Merged

Migrate MapView to react function components #408

merged 35 commits into from
Jul 12, 2024

Conversation

caspg
Copy link
Contributor

@caspg caspg commented Jun 18, 2024

Description

Migrates class to function components.

This is continuation of closed PR #263

Added your feature that allows ...

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I formatted JS and TS files with running yarn lint:fix in the root folder
  • I have run tests via yarn test in the root folder
  • I updated the documentation with running yarn generate in the root folder
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/updated a sample (/example)

Screenshot OR Video

WingmanImd and others added 28 commits February 7, 2024 21:17
@WingmanImd
Migrated MapView and NativeBridge component to function components an…
ecd9218 
…d hooks. Fixed MapView docs
@WingmanImd
Fixed MapView broken doc page caused by eslint
bb8c866
@WingmanImd
Removed unused hook call and update the dependency list of the native…
af70733 
…Props useMemo
@WingmanImd
Merge remote-tracking branch 'upstream/main'
184fd54
@WingmanImd
Migrated react components to function components
431b84f
@caspg
Update CONTRIBUTING.md
eccf4e3
@caspg
update Camera.test
494d57c
@caspg
use jest.mock instead of prop for testing
6899814
@caspg
update Callout test
90828e4
@caspg
migrate UserLocation to functional component
829b211
@caspg
fix TS issue
a7c203b
@caspg
migrate Annotation.tsx to functional component
20e6fff
@caspg
convert ShapeSource to functional component
e6679ef
@caspg
migrate PointAnnotation to functional component
5954764
@caspg
remove AbstractSource and NativeBridgeComponent
dea238c
@caspg
Delete NativeBridgeComponent.tsx
d315f88
@caspg
small updates
a2a168c
@caspg
Update MapView.tsx
c68bcd9
@caspg
rename Mapbox -> MapLibre
79dec87
@caspg
eslint updates
0eec5fb
@caspg
Update UserLocation.tsx
aab6e87
@caspg
Update ShapeSource.tsx
b102290
@caspg
fix eslint warnings and errors
0a908bb
@caspg
changes from yarn dlx @yarnpkg/sdks vscode
7a5649c
@caspg
fix camera test
3832ba4
@caspg
fix autogenerated documentiation
a74d031
@caspg
linting
1f4bd8c
@caspg
Update docs.json
5faf0cb
@caspg caspg changed the title [DRAFT] Migrate MapView to react function components Migrate MapView to react function components Jun 25, 2024
@tyrauber
Copy link
Sponsor Collaborator

Really, really nice job, @caspg and @WingmanImd! This looks fantastic! Appreciate you both making this happen.

@tyrauber tyrauber merged commit 8bebd49 into maplibre:main Jul 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caspg @tyrauber @WingmanImd