Updating local mbtiles file causes crash #2523
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the filesystem with a new version.
for more information, see https://pre-commit.ci
I would be happy to, but is there documentation somewhere on how to do this? |
|
You would need to add it here: https://github.com/maplibre/maplibre-native/blob/main/test/storage/mbtiles_file_source.test.cpp What platform are you on? For CMake there is the |
timonmw
approved these changes
Jun 24, 2024
I am on iOS. Thanks for the tip on where to start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #100 where updating a local
mbtilesfile with a new version will cause a crash.The use case for this is for users that have
mbtilesfiles on the filesystem an update that with a newer version of the file, such as downloading an updated map file. Previously this would crash.