Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not interpolate zoom during flyTo when start and end zoom are same #2479

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Jun 6, 2024

When using flyTo zoom should not be interpolated during the transition. This was causing flickering of labels. Fixes #2477

video_2024-06-06_20-06-18.mp4

@louwers louwers added bug Something isn't working android labels Jun 6, 2024
@louwers louwers self-assigned this Jun 6, 2024
@louwers louwers marked this pull request as draft June 6, 2024 18:29
@louwers
Copy link
Collaborator Author

louwers commented Jun 6, 2024

Oops, this defeats the purpose of the flyTo algorithm. I hope the tests fail otherwise we need to add some test coverage for it.

Will look for another way to fix the problem.

Copy link

github-actions bot commented Jun 6, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2479-compared-to-main.txt

Copy link

github-actions bot commented Jun 6, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +216  +0.0%     +24    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2479-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +21% +24.1Mi  +409% +24.4Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2479-compared-to-legacy.txt

Copy link

github-actions bot commented Jun 6, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0011         -0.0011             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2479-compared-to-main.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android bug Something isn't working
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Label Blinking Issue at Integer Zoom Levels with animateCamera
2 participants