Move Node.js package.json to platform/node

[louwers]

I want to split the package.json for the Node.js package and the package.json used to define the dependencies for the various scripts used. Will probably fail.

@acalcutt What do you think about this?

I probably need to update a few other paths.

Closes #1334

[github-actions]

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2343-compared-to-main.txt

[github-actions]

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2343-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +21% +24.7Mi  +411% +24.6Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2343-compared-to-legacy.txt

[github-actions]

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0069         +0.0067             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2343-compared-to-main.txt

[acalcutt]

I added some changes to merge into this in your repo
louwers#12

This fixes the node-release workflow so it will work with these changes

[louwers]

@acalcutt Awesome!

[acalcutt]

Seemed to work fine to me in my test fork. I would have to cherry pick this into the opengl-2 to keep it in line with this.

One thing to note is I think this makes it harder to make a package that can build on it's own, like my attempt in #535 . From my testing there though, this package is kind of heavy to build on the fly anyway so I'm not sure that is a good approach.

For package.json, I wonder if the dev dependencies can be trimmed down any... I doubt all those are used by the package.

[acalcutt]

One thing I just noticed is how does the ci pass if there is no new package-lock.json?

Edit: Oh I see, the

      - name: npm ci
        run: npm ci --ignore-scripts

is actually part of the maplibre-native build, so it is not in the node directory.

[acalcutt]

The only other thing I see is maybe there should be a package-lock.json in 'platform/node'. I had that in my directory when testing the release. I think it is needed because the publish step does a 'npm ci --ignore-scripts', which would check that file.

[birkskyum]

Great idea. Alternatively to a package lock inside the node, we could add a pnpm-workspace.yml and use pnpm in ci as well