Android annotations: Implement CollisionGroup
#2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## android-annotations #2304 +/- ##
========================================================
- Coverage 85.73% 59.85% -25.88%
========================================================
Files 568 580 +12
Lines 28027 28530 +503
Branches 0 11093 +11093
========================================================
- Hits 24030 17078 -6952
- Misses 3997 4229 +232
- Partials 0 7223 +7223 ☔ View full report in Codecov by Sentry. |
louwers
reviewed
Apr 22, 2024
| @@ -0,0 +1,121 @@ | |||
| package org.maplibre.android.annotations | |||
|
|
|||
| import okhttp3.internal.toImmutableList | |||
There was a problem hiding this comment.
We should probably not use internal packages.
louwers
reviewed
Apr 22, 2024
| import org.maplibre.android.annotations.data.Defaults | ||
| import kotlin.properties.Delegates | ||
|
|
||
| class CollisionGroup( |
There was a problem hiding this comment.
Needs some documentation.
louwers
requested changes
Apr 22, 2024
louwers
reviewed
Apr 22, 2024
| @@ -1054,6 +1056,10 @@ public void addAnnotations(@NonNull KAnnotation... annotations) { | |||
| } | |||
| } | |||
|
|
|||
| public void addCollisionGroup(@NonNull CollisionGroup collisionGroup) { | |||
There was a problem hiding this comment.
Needs a documentation comment.
louwers
reviewed
Apr 22, 2024
| @@ -1090,6 +1096,10 @@ public void removeAnnotations(@NonNull KAnnotation... annotations) { | |||
| } | |||
| } | |||
|
|
|||
| public void removeCollisionGroup(@NonNull CollisionGroup collisionGroup) { | |||
There was a problem hiding this comment.
Needs a documentation comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android annotations API proposal implementation PR as a part of #1491. Closes #1495.
CollisionGroupis implemented per specification. In effect, it is somewhat of a wrapper aroundSymbolManager.CollisionGroupTestcontains some tests I found to be helpful.symbolsis currently immutable, and can be set to a new value through assignment (which we listen to usingDelegates.observable). We could decide to addadd(Symbol),delete(Symbol), etc. instead.