[FEATURE] Returns layer Id on Feature Tap #475
Conversation
| final snackBar = SnackBar( | ||
| content: Text( | ||
| 'Tapped feature with id $featureId', | ||
| 'Tapped feature with id $featureId on payer $layerId', |
There was a problem hiding this comment.
| 'Tapped feature with id $featureId on payer $layerId', | |
| 'Tapped feature with id $featureId on layer $layerId', |
| @@ -56,9 +56,9 @@ class MapLibreMapController: NSObject, FlutterPlatformView, MLNMapViewDelegate, | |||
| target: self, | |||
| action: #selector(handleMapTap(sender:)) | |||
| ) | |||
| for recognizer in mapView.gestureRecognizers! where recognizer is UITapGestureRecognizer { | |||
| /*for recognizer in mapView.gestureRecognizers! where recognizer is UITapGestureRecognizer { | |||
There was a problem hiding this comment.
My bad, this was to enhanced the speed of the callback, with this commented the interaction callback switch from 1s to 0.1s. I was unable to remove all the slow gestureRecognizers
There was a problem hiding this comment.
Workaround is still there — did you find another reason to keep it?
There was a problem hiding this comment.
No, but I haven't been able to find a good solution for this important delay. Perhaps you have an idea?
| @@ -8,7 +8,7 @@ typedef OnMapClickCallback = void Function( | |||
| Point<double> point, LatLng coordinates); | |||
|
|
|||
| typedef OnFeatureInteractionCallback = void Function( | |||
| dynamic id, Point<double> point, LatLng coordinates); | |||
| dynamic id, Point<double> point, LatLng coordinates, String layerId); | |||
There was a problem hiding this comment.
My issue with this is that it changes the callback function signature. Fine since the library is not stable yet. But maybe it's type to make a InteractionEvent class to package all the attributes inside?
There was a problem hiding this comment.
Why not, but I don't think it's necessary, given that functionality is vital.
This reverts commit fdc7fa5.
This is needed to fix a crash on Android 15 due to 16k page
|
Hi @LouisRaverdy, I agree this is a much needed feature. Through, there are still unresolved conversations and it introduces breaking API changes. I'm fine if we skip 0.20.1 and directly go for a breaking 0.21.0 release but please ensure that all open conversations are solved, then I can review and merge your pr. |
Hello MapLibre Team !
I needed to retrieve the layer Id of the feature tapped, so I've implemented it.
This is much cleaner than using the given Id to have a unique identifier and the layer id.
Best regards,
Louis