Fix firefox deserialization + fix from_reader #31
+15
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandrean
requested changes
Oct 15, 2024
Comment on lines
+204
to
+209
| #[serde(default = "default_fsize_maybe")] | ||
| pub send: Option<f64>, | ||
| #[serde(default = "default_fsize_maybe")] | ||
| pub wait: Option<f64>, | ||
| #[serde(default = "default_fsize_maybe")] | ||
| pub receive: Option<f64>, |
There was a problem hiding this comment.
According to the HAR v1.3 draft spec, send, wait and receive are all required fields. They even explicitly write that they are not optional, see:
https://github.com/ahmadnassri/har-spec/blob/master/versions/1.3.md#timings
mandrean
requested changes
Oct 15, 2024
Comment on lines
+198
to
+203
| #[serde(default = "default_fsize_maybe")] | ||
| pub send: Option<f64>, | ||
| #[serde(default = "default_fsize_maybe")] | ||
| pub wait: Option<f64>, | ||
| #[serde(default = "default_fsize_maybe")] | ||
| pub receive: Option<f64>, |
There was a problem hiding this comment.
According to the HAR v1.2 spec, send, wait and receive are all required fields. They even explicitly write that they are not optional, see:
http://www.softwareishard.com/blog/har-12-spec/#timings
|
Hey @grelner, thanks for opening the PR! Can the Firefox issue you're describing be solved without breaking the HAR v1.2 and v1.3 specs? Also a test reproducing the Firefox issue would be nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two things: