Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the CFF Explorer icon to the right click & fix uninstallation #1108

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

Ana06
Copy link
Member

@Ana06 Ana06 commented Jul 17, 2024

Add the CFF Explorer icon to the right click menu option. Installing CFF Explorer adds it to the right click menu for several file extensions (without icon). Delete the registry subkeys for the concrete file extensions to ensure the one we create for all extensions applies.

image

Closes #1101

When uninstalling CFF Explorer, the right click menu option was not being removed because the
wrong name was being used. Correct the name to fix it.

Add the CFF Explorer icon to the right click menu option. Installing CFF
Explorer adds it to the right click menu for several file extensions
(without icon). Delete the registry subkeys for the concrete file
extensions to ensure the one we create for all extensions applies.
CFF Explorer right click menu option was not being removed because the
wrong name was being used. Correct the name to fix it.
@Ana06 Ana06 added 💎 enhancement It is working, but it could be better 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Jul 17, 2024
@Ana06 Ana06 requested a review from a team July 17, 2024 11:09
@Ana06 Ana06 self-assigned this Jul 17, 2024
@Ana06 Ana06 changed the title Cff icon Add the CFF Explorer icon to the right click & fix uninstallation Jul 17, 2024
Copy link
Contributor

@binjo binjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ana06 Ana06 merged commit 6a3021c into mandiant:main Jul 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open with CFF explorer is missing icon
2 participants