Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CI and libamambapy tests (on Unix) #2952

Merged
merged 9 commits into from
Nov 2, 2023

Conversation

AntoinePrv
Copy link
Member

  • Add simple libmambapy test
  • Use CMakePresets in CI

@AntoinePrv AntoinePrv force-pushed the libmambapy-test branch 16 times, most recently from 59c150a to 5fec0c9 Compare October 30, 2023 17:00
@AntoinePrv
Copy link
Member Author

@jonashaag @pavelzw Any idea why I cannot delete that cache? I feel like I read all possible doc and tried all possible combination of secrets / tokens / environment variables / permissions...

@pavelzw
Copy link
Member

pavelzw commented Oct 30, 2023

I've never done this sort of stuff in CI, only with my local PAT 👀

@jonashaag
Copy link
Collaborator

Can you give more context please? What exactly are you trying to do that doesn't work? Is it a solution for you to manually delete the cache through GitHub's UI?

@AntoinePrv
Copy link
Member Author

I just want to divide the workflow into build > test-libmamba | test-libmambapy | test-micromamba, but apparently there is no easy way to share data between jobs.

I don't understand how using artifacts is Github's recomended solution: it's very annoying to get a proper key, and it will definitly blow up the storage data, when all you want is to share data for the short lived duration of the workflow 🤷

@jonashaag
Copy link
Collaborator

Hmm yeah probably there is not good way to do this in GHA.

@AntoinePrv
Copy link
Member Author

Permission denied, now. How user unfriendly does this have to be 🙄

@AntoinePrv AntoinePrv force-pushed the libmambapy-test branch 6 times, most recently from 0ce8c8d to 7de9e72 Compare October 31, 2023 16:33
@AntoinePrv AntoinePrv force-pushed the libmambapy-test branch 5 times, most recently from 220e77d to 3783ee4 Compare November 2, 2023 11:21
@AntoinePrv AntoinePrv changed the title Refactor CI and libamambapy tests Refactor CI and libamambapy tests (on Unix) Nov 2, 2023
@AntoinePrv
Copy link
Member Author

@JohanMabille since this also fix a bug related to pytest.skip and that the Unix part is completed, we could merge and continue the windows changes in a follow-up PR.

@AntoinePrv AntoinePrv merged commit fdf2b65 into mamba-org:main Nov 2, 2023
26 checks passed
@AntoinePrv AntoinePrv deleted the libmambapy-test branch November 2, 2023 12:55
delsner added a commit to delsner/mamba that referenced this pull request Nov 23, 2023
jonashaag pushed a commit that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants