-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatible with php 8.2 #7
Conversation
Cool, I need it too! |
Me too. Please merge this pull request. By the way, there are still some errors in lib/Configuration.php |
@Moishe Could you merge this pull request? |
Looks like you can not make them protected. They need to be public. |
Hi there! As noted in this project's README, this is an autogenerated project. PRs should be sent to https://github.com/mailchimp/mailchimp-client-lib-codegen I don't work at Mailchimp anymore so unfortunately can't merge any PRs to any projects. However I'll ping some folks who are still there to give them a heads-up that there might be a PR coming on the codegen project. |
The methods need to be made public, starting from allowlists to whitelists... would be grand to have that updated and merged. |
As I said, I don't think anyone from Mailchimp is monitoring this thread (or this repo). You might have better luck over on the repo I linked to above. |
I made new pull request |
Tnx for the pull-request. The properties need to public, not protected. Protected throws an error. |
show me error. |
This generates following error: |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, renaming $Configuration to $config is pure personal preference and totally unnecessary. What's the reason for this change?
I've made my own fork with php8 support. I can't wait. For fix: composer rm mailchimp/transactional
composer require otis22/transactional |
Should be fixed according to #8 (comment) |
Closing as this has been fix already Please upgrade to the most recent version, thanks |
Error occurs when using php 8.2
Creation of dynamic property MailchimpTransactional\Api\AllowlistsApi::$config is deprecated.