Renamed PRIMARY_HOSTNAME to BOX_HOSTNAME #2465
Conversation
using "primary" to describe the domain of the box / mail server is confusing when working with multiple domains. Usually the box domain is different from the domain you want to host your mail for.
|
I really can't foresee ever taking the time to review this. |
|
Is there anyone else on the project that could take time to review it? |
|
This is too large for too little gain. A cursory glance also shows python renames and not just the global var. This feels like a change that is high risk for just a rename. Also I’m familiar with the old name. So there would be some relearning when reviewing future PRs |
|
I completely understand that this is a big change, but making the structure more manageable and making the variable names have a meaning is really important to help new developers familiarize with the project and understand how it works. I don't think I'm able to work on the new feature without doing some refactoring, as the next PR would have had a split and refactor of the management/mailconfig.py file. That would've been a big change too, so maybe it's better for me to drop this. |
This project is in a phase where high-risk changes are extremely difficult to get past the finish line. The folks who worked on the quota PR have been incredibly patient in waiting years to get through review. |
While I was working on the new domain management I found that the use of primary while talking about hostname or domains was getting a bit too confusing, so I decided to rename all things related to "primary" to something that makes more sense given the context around the code.
This is a big change in the codebase and I don't want it to be merged together with the new domains system, so I'm making a pull request just for this.
I've also added ruff files for linting and a dev-requirements.txt file with the python requirements found in
setup/management.shso that devs can create a virtualenv, install from the file and have type hints when using editors like vscode.